Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rem/mod doc #21223

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Fix rem/mod doc #21223

merged 1 commit into from
Mar 29, 2017

Conversation

yuyichao
Copy link
Contributor

Unbreak Colors.jl. Not sure if/how to test......

@yuyichao yuyichao added the docs This change adds or pertains to documentation label Mar 29, 2017
ararslan
ararslan approved these changes Mar 29, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@ararslan ararslan merged commit d266f92 into master Mar 29, 2017
@ararslan ararslan deleted the yyc/doc/rem branch March 29, 2017 21:19
@tkelman
Copy link
Contributor

tkelman commented Mar 29, 2017

what about this broke Colors.jl? should something be throwing a MethodError that wasn't?

@ararslan
Copy link
Member

That was my fault. The way I did it in my PR inadvertently added a method that shouldn't have been there.

@tkelman
Copy link
Contributor

tkelman commented Mar 29, 2017

can we test the "shouldn't have been there" part? what method, and what problems did it cause?

@ararslan
Copy link
Member

Not sure. @yuyichao noted the failure and the cause, perhaps he knows.

@tkelman
Copy link
Contributor

tkelman commented Mar 30, 2017

looks like it was causing an ambiguity

@timholy timholy mentioned this pull request Mar 30, 2017
Merged
@iamnapo iamnapo mentioned this pull request Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyichao @tkelman @ararslan